fix: collision-aware !path hop resolution - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Rewrote
!pathpath-hop resolution (commands/path.py) so a far repeater that merely shares a path-hash prefix can no longer supply a bogus distance.type IN (repeater, room)contacts (clients never repeat), shrinking the collision pool.Why
During a tropospheric-ducting event, far repeaters (Louisiana/Dallas/Texarkana) were auto-added as contacts. One collided on its 2-byte path hash with a local repeater; the local (correct) hop had no geo, so the old "exactly one located contact" guard was silently defeated and
!pathreported the Louisiana location/distance. The fix detects the collision instead of trusting the only geo'd candidate.Notes
self_info.adv_lat/lon) improves disambiguation.tests/test_path_resolve.py— impostor-collision → unlocated, two-geo collision → nearest-to-bot, unique far hop trusted, client excluded, geoless unique → unlocated, sender-as-anchor fallback.Breaking changes
None. Pure accuracy fix; output format unchanged.