Repository navigation
refactor: always decrypt RX_LOG, remove rx_log_decrypt setting - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
[bot] rx_log_decryptsetting. The client-side RX_LOG decrypt+ingest and the library's channel-log decryption are now always on.Why
rx_log_decryptonly ever gated client-side decryption, but with itfalse:!pathlost the routing path for channel messages (the path back-fill is correlated via decrypted RX_LOG logs), andThe overhead of always decrypting is negligible (AES/HMAC per channel frame; one X25519 per DM frame), and the radio's private key is exported unconditionally anyway, so the only thing the toggle bought was a "capture-only / metadata-only" mode. For a command hub the priority is maximum usable data, so always-on wins:
!pathalways works, channels beyond the radio's slot capacity are always covered, and therx_log_decrypt↔!pathfootgun is gone.Changes
mcbot.py: drop theConfig.rx_log_decryptfield + parse;set_decrypt_channel_logs(True)unconditionally; subscribeRX_LOG_DATAunconditionally; drop it from the startup banner; refresh comments. Queue/RX_LOG dedup unchanged.mcbot.conf.example: remove therx_log_decryptstanza; trim the stale note in therepeat_trackingdocs.Bot_Usage.md: remove the config-table row and the capture-only sentence; reword to "always on."Consequence
The firehose now always shows decoded RX_LOG channel text — the capture-only/metadata-only mode is intentionally removed.
Testing
py_compileclean;Configno longer exposesrx_log_decrypt; all five test suites (logging, repeat-tracking, eviction, decode-advert, advert-interval) pass; no references remain repo-wide.