Fixed the error reporting for untagged enum errors#3047
Open
c0pp3rdru1d wants to merge 1 commit intoserde-rs:masterfrom
Open
Fixed the error reporting for untagged enum errors#3047c0pp3rdru1d wants to merge 1 commit intoserde-rs:masterfrom
c0pp3rdru1d wants to merge 1 commit intoserde-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I improved error reporting for “partially untagged” enums (enums with tagged variants followed by #[serde(untagged)] fallbacks). Previously, when the tagged variants failed and deserialization fell through to the untagged variants, the tagged error was discarded and the final message could be uninformative.
This change collects the error from the initial tagged attempt and the errors from each untagged variant attempt, then combines them into a single data did not match any variant… message (unless a custom #[serde(expecting = ...)] is provided). We also added/updated test coverage for the expected error output so this diagnostic behavior doesn’t regress.