fix: refine feature flag conditions for Arc and Rc implementations to include target_has_atomic checks#2924
Open
zouguangxian wants to merge 1 commit intoserde-rs:masterfrom
Conversation
Author
|
@dtolnay, can you give some suggestions about this feature? |
… include target_has_atomic checks This commit enables building serde for the `riscv32im-unknown-none-elf` target. `cargo build -p serde --no-default-features --features="rc,alloc" --target riscv32im-unknown-none-elf`
5e4dce7 to
7e689e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables building serde for the
riscv32im-unknown-none-elftarget.cargo build -p serde --no-default-features --features="rc,alloc" --target riscv32im-unknown-none-elf