Skip to content

Convert method table.extend() to a local function because 'table' is … #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tom93 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert method table.extend() to a local function because 'table' is … #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions base.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ QlessRecurringJob.__index = QlessRecurringJob
Qless.config = {}

-- Extend a table. This comes up quite frequently
function table.extend(self, other)
local function extend_table(target, other)
for i, v in ipairs(other) do
table.insert(self, v)
table.insert(target, v)
end
end

Expand Down
4 changes: 2 additions & 2 deletions queue.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ function QlessQueue:peek(now, count)

-- With these in place, we can expand this list of jids based on the work
-- queue itself and the priorities therein
table.extend(jids, self.work.peek(count - #jids))
extend_table(jids, self.work.peek(count - #jids))

return jids
end
Expand Down Expand Up @@ -322,7 +322,7 @@ function QlessQueue:pop(now, worker, count)

-- With these in place, we can expand this list of jids based on the work
-- queue itself and the priorities therein
table.extend(jids, self.work.peek(count - #jids))
extend_table(jids, self.work.peek(count - #jids))

local state
for index, jid in ipairs(jids) do
Expand Down