Skip to content

Fixed Romanian translations links. - #494

Closed
kinkod wants to merge 2 commits into
semver:gh-pagesfrom
epigrade:fix/ro
Closed

kinkod wants to merge 2 commits into
semver:gh-pagesfrom
epigrade:fix/ro

Conversation

@kinkod

@kinkod kinkod commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

  • [x ] This PR doesn't modify the files in the spec dir.
  • [ x] This PR passes npm run lint.
  • (Optional) If you're willing to help reviews about your language's translations, add your name to the TRANSLATORS.md.

@vercel

vercel Bot commented Jan 7, 2026

Copy link
Copy Markdown

@kinkod is attempting to deploy a commit to the Yuki Okushi's projects Team on Vercel.

A member of the Team first needs to authorize it.

@kinkod

kinkod commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

The Vercel check shows ‘Authorization required to deploy’ (likely fork protection / env vars). Could a maintainer authorize the preview deployment, or let me know if this check isn’t required for this PR?

@JohnTitor

Copy link
Copy Markdown
Member

Because we currently use my hobby plan on Vercel (I really hope we could use some OSS plan but not happened yet).

So about the changes, I'd like to remove them instead as we don't have bandwidth to verify external domains (it could be a bad actor's target potentially).
We could put acknowledgement associated with GitHub users, and that way resolves this issue.
Anyway removing is enough for now, I think.

@kinkod

kinkod commented Jan 10, 2026

Copy link
Copy Markdown
Contributor Author

The only reason i could afford to make the romanian translation possible is because i could get some dofollow links from semver.org domain for SEO purposes. It was a win-win situation. Allowing a few credits links opens the door for SEOs to invest their time to do translations because they have something to gain. My boss would not allow you to use our romanian translation without the links because it would be a loss for him. As a matter of fact we were discussing doing more translations (paying north of 150eur/translation to a proffessional translator) to get more links to our websites.

So, with that in mind, let me know how you wish to proceed.

@JohnTitor

Copy link
Copy Markdown
Member

Hey sorry for the delay to get back. We concluded that we shouldn't link to external websites for SEO purposes and want to remove external links.

My boss would not allow you to use our romanian translation without the links because it would be a loss for him.

I've also dropped the Romanian translations for now. If your boss accepts without links, please get it back.

@JohnTitor JohnTitor closed this Jan 21, 2026

@Chewypewy Chewypewy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants