chore: change pco upgrade path

[JasonPowr]

No description provided.

[qodo-for-securesign]

PR Summary by Qodo

Change PCO upgrade source channel to stable for OCP 4.16–4.22

⚙️ Configuration changes 🕐 Less than 10 minutes

AI Description

• Switch Policy Controller Operator upgrade source channel from tech-preview to stable.
• Apply the same upgrade-path change across OCP 4.16 through 4.22 Konflux patches.

Diagram

graph TD
P["Konflux PCO pipeline"] --> T["Upgrade task"] --> O{{"OLM / Catalog"}}
T --> F["patch.yaml (v4.16–v4.22)"] --> V["UPGRADE_FROM_CHANNEL=stable"]
T --> C["UPGRADE_TO_CHANNEL={{.installChannel}}"] --> O
subgraph Legend
direction LR
_file["Config file"] ~~~ _task["Pipeline task"] ~~~ _ext{{"External system"}}
end

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Centralize UPGRADE_FROM_CHANNEL in a shared base/values file

• ➕ Avoids repeating the same change across every OCP version directory
• ➕ Reduces risk of future version drift (some versions updated, others missed)
• ➖ Requires refactoring the Konflux/Kustomize overlay structure
• ➖ May be harder to support if specific OCP versions legitimately need different channels

2. Drive channel selection via a pipeline parameter (with a stable default)

• ➕ Enables controlled experiments/rollbacks without config churn
• ➕ Keeps versioned patch files minimal
• ➖ Adds parameter plumbing and validation to the pipeline
• ➖ Increases surface area for misconfiguration at runtime

Recommendation: The PR’s approach is appropriate if the intent is a consistent policy change across all supported OCP versions. If channel changes are expected to recur, consider centralizing the value (or parameterizing it) to prevent future inconsistencies across versioned patch directories.

Files changed (7) +7 / -7

Other (7) +7 / -7

patch.yamlSet PCO upgrade source channel to stable +1/-1

Set PCO upgrade source channel to stable

• Changes UPGRADE_FROM_CHANNEL from "tech-preview" to "stable" for the OCP 4.16 PCO patch configuration. This updates the expected upgrade path resolution for that version.

konflux-configs/base/project/base/ocp/pco/v4.16/patch.yaml

patch.yamlSet PCO upgrade source channel to stable +1/-1

Set PCO upgrade source channel to stable

• Changes UPGRADE_FROM_CHANNEL from "tech-preview" to "stable" for the OCP 4.17 PCO patch configuration. This aligns upgrades with the stable channel baseline.

konflux-configs/base/project/base/ocp/pco/v4.17/patch.yaml

patch.yamlSet PCO upgrade source channel to stable +1/-1

Set PCO upgrade source channel to stable

• Changes UPGRADE_FROM_CHANNEL from "tech-preview" to "stable" for the OCP 4.18 PCO patch configuration. This standardizes upgrade sourcing to stable for that release.

konflux-configs/base/project/base/ocp/pco/v4.18/patch.yaml

patch.yamlSet PCO upgrade source channel to stable +1/-1

Set PCO upgrade source channel to stable

• Changes UPGRADE_FROM_CHANNEL from "tech-preview" to "stable" for the OCP 4.19 PCO patch configuration. This affects the upgrade graph starting point used by the pipeline.

konflux-configs/base/project/base/ocp/pco/v4.19/patch.yaml

patch.yamlSet PCO upgrade source channel to stable +1/-1

Set PCO upgrade source channel to stable

• Changes UPGRADE_FROM_CHANNEL from "tech-preview" to "stable" for the OCP 4.20 PCO patch configuration. This moves upgrades off the tech-preview baseline.

konflux-configs/base/project/base/ocp/pco/v4.20/patch.yaml

patch.yamlSet PCO upgrade source channel to stable +1/-1

Set PCO upgrade source channel to stable

• Changes UPGRADE_FROM_CHANNEL from "tech-preview" to "stable" for the OCP 4.21 PCO patch configuration. This ensures the upgrade task resolves from stable for this version.

konflux-configs/base/project/base/ocp/pco/v4.21/patch.yaml

patch.yamlSet PCO upgrade source channel to stable +1/-1

Set PCO upgrade source channel to stable

• Changes UPGRADE_FROM_CHANNEL from "tech-preview" to "stable" for the OCP 4.22 PCO patch configuration. This aligns upgrade behavior with the stable channel across versions.

konflux-configs/base/project/base/ocp/pco/v4.22/patch.yaml

[github-actions]

Configuration Diff

7 document(s) impacted:

+ 0 added
- 0 removed
! 7 modified

Diff

@@ spec.resources.appstudio.redhat.com/v1beta2/IntegrationTestScenario/{{.application}}{{.nameSuffix}}-v4-16-upgrade.spec.params.UPGRADE_FROM_CHANNEL.value @@
# projctl.konflux.dev/v1beta1/ProjectDevelopmentStreamTemplate/rhtas-tenant/pco-fbc-template
! ± value change
- tech-preview
+ stable

@@ spec.resources.appstudio.redhat.com/v1beta2/IntegrationTestScenario/{{.application}}{{.nameSuffix}}-v4-17-upgrade.spec.params.UPGRADE_FROM_CHANNEL.value @@
# projctl.konflux.dev/v1beta1/ProjectDevelopmentStreamTemplate/rhtas-tenant/pco-fbc-template
! ± value change
- tech-preview
+ stable

@@ spec.resources.appstudio.redhat.com/v1beta2/IntegrationTestScenario/{{.application}}{{.nameSuffix}}-v4-18-upgrade.spec.params.UPGRADE_FROM_CHANNEL.value @@
# projctl.konflux.dev/v1beta1/ProjectDevelopmentStreamTemplate/rhtas-tenant/pco-fbc-template
! ± value change
- tech-preview
+ stable

@@ spec.resources.appstudio.redhat.com/v1beta2/IntegrationTestScenario/{{.application}}{{.nameSuffix}}-v4-19-upgrade.spec.params.UPGRADE_FROM_CHANNEL.value @@
# projctl.konflux.dev/v1beta1/ProjectDevelopmentStreamTemplate/rhtas-tenant/pco-fbc-template
! ± value change
- tech-preview
+ stable

@@ spec.resources.appstudio.redhat.com/v1beta2/IntegrationTestScenario/{{.application}}{{.nameSuffix}}-v4-20-upgrade.spec.params.UPGRADE_FROM_CHANNEL.value @@
# projctl.konflux.dev/v1beta1/ProjectDevelopmentStreamTemplate/rhtas-tenant/pco-fbc-template
! ± value change
- tech-preview
+ stable

@@ spec.resources.appstudio.redhat.com/v1beta2/IntegrationTestScenario/{{.application}}{{.nameSuffix}}-v4-21-upgrade.spec.params.UPGRADE_FROM_CHANNEL.value @@
# projctl.konflux.dev/v1beta1/ProjectDevelopmentStreamTemplate/rhtas-tenant/pco-fbc-template
! ± value change
- tech-preview
+ stable

@@ spec.resources.appstudio.redhat.com/v1beta2/IntegrationTestScenario/{{.application}}{{.nameSuffix}}-v4-22-upgrade.spec.params.UPGRADE_FROM_CHANNEL.value @@
# projctl.konflux.dev/v1beta1/ProjectDevelopmentStreamTemplate/rhtas-tenant/pco-fbc-template
! ± value change
- tech-preview
+ stable

---

_{📦 Artifacts: base-output.yaml, head-output.yaml, dyff-output.txt}

[qodo-for-securesign]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}