Repository navigation
fix: apply Agent Detector confidence slider to the confidence filter - #20
Merged
codelion merged 3 commits intoOct 2, 2026
Merged
Conversation
The "Detection Confidence" slider was passed to non_max_suppression as the IoU threshold while the confidence filter was hardcoded at 0.5, so raising the slider let more overlapping boxes through and never filtered on confidence. Use the slider value for the confidence filter and leave NMS at its default IoU of 0.5.
Emart29
force-pushed
the
fix/agent-detector-confidence-threshold
branch
from
October 2, 2026 00:31
f821864 to
361b8c8
Compare
codelion
force-pushed
the
fix/agent-detector-confidence-threshold
branch
from
October 2, 2026 01:41
69e1277 to
aaf6128
Compare
It was not working and would fail PR checks.
codelion
force-pushed
the
fix/agent-detector-confidence-threshold
branch
from
October 2, 2026 01:41
aaf6128 to
83b2a44
Compare
Unit tests use a fake OpenAI client, including regression tests for the confidence slider. A model-marked test runs the plugin end to end against Qwen3.5-0.8B on CPU. GitHub Actions runs both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Detection Confidence" slider on the Plugins page was passed to
non_max_suppressionas the IoU threshold, while the confidence filter was hardcoded at 0.5. Raising the slider therefore let more overlapping boxes through and never filtered on confidence.This change uses the slider value for the confidence filter and leaves NMS at its default IoU of 0.5. The comparison is now
>=, so a slider at 1.0 doesn't drop a detection with confidence 1.0.Checked with a stubbed model reply of four boxes (confidences 0.9, 0.6, 0.3, plus a 0.7 box overlapping the 0.9 one):
Not tested against the live Gemini endpoint.