Repository navigation
#6276 Fix filesystem path processing for cache - #6390
Merged
Merged
Conversation
akleshchev
requested review from
maxim-productengine
and
a lite review from Copilot
September 29, 2026 18:58
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A moderate path-encoding issue and a header dependency issue remain unresolved.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Fixes filesystem path conversion crashes in disk-cache processing, especially on Windows.
Changes:
- Uses UTF-8-aware
fsyspathconversions for cache paths. - Updates cache cleanup, matching, and size calculations.
| File | Summary |
|---|---|
indra/llfilesystem/lldiskcache.cpp |
Updates cache path handling. A moderate issue remains with UTF-8 paths passed to std::filesystem::remove (4 votes), and a nit requests a direct fsyspath.h include (1 vote). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akleshchev
force-pushed
the
andreyk/viewer_6276_2
branch
from
September 29, 2026 19:16
d2b6d60 to
9a2e95a
Compare
marchcat
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically a crash fix for a crash on path().string().