Move GLTF files into own project - #6210
Draft
akleshchev wants to merge 2 commits into
Draft
Conversation
akleshchev
marked this pull request as draft
August 27, 2026 19:25
akleshchev
force-pushed
the
andreyk/viewer_gcp
branch
4 times, most recently
from
August 27, 2026 20:47
30270f7 to
c3c9b5a
Compare
Collaborator
|
Seems reasonable @akleshchev - have you tried a viewer build and uploaded a GLTF mesh with this yet? Or taken a look at some PBR materials in-world with this change? |
Contributor
Author
Local build is fine. Haven't tried GH one. This simply moves files, if something was wrong it would have failed. But I'm constantly postponing moving llgltfmaterial, which is why this is till draft. Sadly primitive project depends onto llgltfmaterial. and it is not easy to decouple. |
akleshchev
force-pushed
the
andreyk/viewer_gcp
branch
2 times, most recently
from
September 10, 2026 15:05
101b1f9 to
18f924f
Compare
akleshchev
force-pushed
the
andreyk/viewer_gcp
branch
from
September 10, 2026 17:22
18f924f to
1da938c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move gltf related, non-rendering files into own project.