Skip to content

Align structure names with spec#5

Merged
sdf-jkl merged 1 commit into
sdf-jkl:alpfrom
alamb:alamb/alp_names
May 9, 2026
Merged

Align structure names with spec#5
sdf-jkl merged 1 commit into
sdf-jkl:alpfrom
alamb:alamb/alp_names

Conversation

@alamb
Copy link
Copy Markdown

@alamb alamb commented May 9, 2026

A proposed update to the ALP implementation

Rather than aligning with C++ I think it would make the code easer to understand if the names mirrored what is in the spec, namely

@alamb alamb marked this pull request as ready for review May 9, 2026 10:43
@sdf-jkl sdf-jkl merged commit c912f4e into sdf-jkl:alp May 9, 2026
14 of 16 checks passed
@sdf-jkl
Copy link
Copy Markdown
Owner

sdf-jkl commented May 9, 2026

FYI, parquet crate does fmt via

cargo fmt -p parquet --  --config skip_children=true `find ./parquet -name "*.rs" \! -name format.rs`

@alamb
Copy link
Copy Markdown
Author

alamb commented May 10, 2026

FYI, parquet crate does fmt via

cargo fmt -p parquet --  --config skip_children=true `find ./parquet -name "*.rs" \! -name format.rs`

Sorry I keep breaking this -- will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants