Skip to content

chore: revisit shuffle before persist logic#196

Draft
selmanozleyen wants to merge 2 commits into
scverse:mainfrom
selmanozleyen:chore/revisit-shuffle-before-persist
Draft

chore: revisit shuffle before persist logic#196
selmanozleyen wants to merge 2 commits into
scverse:mainfrom
selmanozleyen:chore/revisit-shuffle-before-persist

Conversation

@selmanozleyen
Copy link
Copy Markdown
Member

fixes: #194

Needs benchmarking against old code to justify refactor.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.59%. Comparing base (39a99c9) to head (db8c511).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   93.48%   91.59%   -1.89%     
==========================================
  Files          14       14              
  Lines        1121     1119       -2     
==========================================
- Hits         1048     1025      -23     
- Misses         73       94      +21     
Files with missing lines Coverage Δ
src/annbatch/io.py 91.53% <100.00%> (+0.21%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit shuffle-before-persist ordering in DatasetCollection writes

1 participant