Feature: Categorical Sampler#136
Draft
selmanozleyen wants to merge 18 commits into
Draft
Conversation
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
…ch_size and drop_last (scverse#132) * add failing tests * update the tests * fix * Update src/annbatch/samplers/_chunk_sampler.py Co-authored-by: Ilan Gold <ilanbassgold@gmail.com> * Update src/annbatch/samplers/_chunk_sampler.py --------- Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 90.80% 88.80% -2.01%
==========================================
Files 10 12 +2
Lines 805 911 +106
==========================================
+ Hits 731 809 +78
- Misses 74 102 +28
🚀 New features to boost your workflow:
|
commit 845053e Author: selmanozleyen <syozleyen@gmail.com> Date: Fri Feb 6 10:32:33 2026 +0100 blunder fix forgot to add worker_id property commit 1e71f0d Author: selmanozleyen <syozleyen@gmail.com> Date: Fri Feb 6 10:27:40 2026 +0100 fix commit 585898d Merge: 4df0a95 c9a5971 Author: Selman Özleyen <32667648+selmanozleyen@users.noreply.github.com> Date: Fri Feb 6 10:10:45 2026 +0100 Merge branch 'main' into fix/rng-handling commit 4df0a95 Author: selmanozleyen <syozleyen@gmail.com> Date: Fri Feb 6 10:04:07 2026 +0100 accurate docstrings commit e3e5739 Author: selmanozleyen <syozleyen@gmail.com> Date: Fri Feb 6 10:01:24 2026 +0100 remove redundant comments commit ffb8041 Author: selmanozleyen <syozleyen@gmail.com> Date: Fri Feb 6 09:59:57 2026 +0100 remove comment commit 2f24aee Merge: a23f01e 8cc3df0 Author: Selman Özleyen <32667648+selmanozleyen@users.noreply.github.com> Date: Fri Feb 6 09:58:33 2026 +0100 Merge branch 'main' into fix/rng-handling commit a23f01e Author: selmanozleyen <syozleyen@gmail.com> Date: Fri Feb 6 09:57:29 2026 +0100 update _spawn_worker_rng commit dafba5f Author: selmanozleyen <syozleyen@gmail.com> Date: Fri Feb 6 09:34:56 2026 +0100 dedup and update commit 25d5908 Author: selmanozleyen <syozleyen@gmail.com> Date: Fri Feb 6 09:31:26 2026 +0100 remove get_part_for_worker commit 6283625 Author: Selman Özleyen <32667648+selmanozleyen@users.noreply.github.com> Date: Fri Feb 6 09:23:14 2026 +0100 Update tests/test_sampler.py Co-authored-by: Philipp A. <flying-sheep@web.de> commit bbc5951 Author: selmanozleyen <syozleyen@gmail.com> Date: Thu Feb 5 14:48:45 2026 +0100 workerhandle takes rng commit 31f4671 Author: selmanozleyen <syozleyen@gmail.com> Date: Thu Feb 5 13:55:29 2026 +0100 update mockworker so it passes all the tests expcept repr commit 1bcbb88 Author: selmanozleyen <syozleyen@gmail.com> Date: Thu Feb 5 13:54:54 2026 +0100 add unit test which fails in main but passes here commit f893c2b Author: selmanozleyen <syozleyen@gmail.com> Date: Thu Feb 5 13:44:24 2026 +0100 fix for rng handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #119