Conversation
❌ Deploy Preview for scipy-org failed.Built without sensitive environment variables
|
|
Hi @goanpeca, thank you! We'll also need to ensure that all of the new shortcodes use double quotes for the values of the parameters, as single quotes are not allowed. I'm not sure how this will work with cases where we need complex multi-line content – hopefully there aren't any. |
Will make the fixes! |
2255664 to
b4f9159
Compare
|
Made the fixes @agriyakhetarpal ! |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thank you, @goanpeca! Perhaps it makes sense to update the figure, button, and image shortcodes in a consolidated PR, as one PR is better and would be easier to review than three (as I commented in https://github.com/pybamm-team/pybamm.org#283). The changes for the image shortcodes look good, though! I haven't run the website locally right now but we should confirm all pages before merging, of course.
b4f9159 to
fd04d16
Compare
c149ce2 to
eea9796
Compare
|
@agriyakhetarpal PRs will fix all. Some projects only use some of the shortcodes. This one has been tested :) |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Sounds good to me! Out of curiosity, what are the extra \ and "" (double double quote markers) at the end of the image URLs for?
|
|
Hello team!
As part of figure, image and button shortcodes as being updated on this PR I created this PR to prepare the website for moving to the new syntax when a new version is released!
Pinging @agriyakhetarpal