Skip to content

ENH: Scipy exceptions#61

Open
HaoZeke wants to merge 3 commits intoscipy:mainfrom
HaoZeke:scipyExceptions
Open

ENH: Scipy exceptions#61
HaoZeke wants to merge 3 commits intoscipy:mainfrom
HaoZeke:scipyExceptions

Conversation

@HaoZeke
Copy link
Copy Markdown

@HaoZeke HaoZeke commented Jul 30, 2023

This is a proof of concept fix for scipy/scipy#15888.

I suppose it would be possible to overload the current strategy of returning integer status values instead, but this feels clearer and cleaner. Exceptions should be 0 cost on most modern hardware, and even Cython has automatic handling for them (see companion scipy PR )

@HaoZeke HaoZeke marked this pull request as draft July 30, 2023 23:19
@HaoZeke
Copy link
Copy Markdown
Author

HaoZeke commented Jul 30, 2023

Marking as a draft until I figure out what's the cleanest place to throw (probably Presolve itself). This now throws a much more informative error, without crashing the interpreter:

Python 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:40:32) [GCC 12.3.0]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.14.0 -- An enhanced Interactive Python. Type '?' for help.
Running HiGHS 1.2.0 [date: 2021-07-09, git hash: n/a]
Copyright (c) 2022 ERGO-Code under MIT licence terms
Presolving model
Memory allocation failed while processing fixedColAtLower: 
Presolve failed, details: Failed to resize the vector. Requested new size: -2142950640. Size to add is 24for . Current size: 2152016632.
End

@HaoZeke HaoZeke marked this pull request as ready for review July 31, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant