ENH: Scipy exceptions#61
Open
HaoZeke wants to merge 3 commits intoscipy:mainfrom
Open
Conversation
Author
|
Marking as a draft until I figure out what's the cleanest place to throw (probably Presolve itself). This now throws a much more informative error, without crashing the interpreter: Python 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:40:32) [GCC 12.3.0]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.14.0 -- An enhanced Interactive Python. Type '?' for help.
Running HiGHS 1.2.0 [date: 2021-07-09, git hash: n/a]
Copyright (c) 2022 ERGO-Code under MIT licence terms
Presolving model
Memory allocation failed while processing fixedColAtLower:
Presolve failed, details: Failed to resize the vector. Requested new size: -2142950640. Size to add is 24for . Current size: 2152016632.
End |
568e14b to
31d630f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept fix for scipy/scipy#15888.
I suppose it would be possible to overload the current strategy of returning integer status values instead, but this feels clearer and cleaner. Exceptions should be 0 cost on most modern hardware, and even Cython has automatic handling for them (see companion
scipyPR )