Fix showing link in table and sidebar [SCI-13419] - #9647
Open
matej-scinote wants to merge 1 commit into
Open
Conversation
matej-scinote
force-pushed
the
mf_SCI_13419
branch
from
August 18, 2026 08:01
3a52c17 to
ca93425
Compare
matej-scinote
marked this pull request as ready for review
August 18, 2026 08:10
| }, | ||
| methods: { | ||
| showTextCellModal() { | ||
| if (event.target.closest('a')) return; // do not open modal if value is a link |
Contributor
There was a problem hiding this comment.
Not sure if it is really reliable way to check that
| <span v-if="textValue && textValue.length > 0" class="cursor-pointer line-clamp-1 leading-[unset]" | ||
| @click.stop="showTextCellModal"> | ||
| {{ textValue}} | ||
| @click.stop="showTextCellModal" v-html="textValue"> |
Contributor
There was a problem hiding this comment.
Do we really want to always use v-html?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: SCI-13419
What was done
Fix showing link in table and sidebar