Design system - buttons restyling (icon-aware padding) [SCI-13284] - #9570
Open
boriskolarov wants to merge 1 commit into
Open
Design system - buttons restyling (icon-aware padding) [SCI-13284]#9570boriskolarov wants to merge 1 commit into
boriskolarov wants to merge 1 commit into
Conversation
Restyle design-system buttons to match the Core Design Figma spec: - Border radius 4px -> 8px across all sizes - Size-specific icon sizes (24/24/20/16 for lg/md/sm/xs) - Size-specific gaps and horizontal padding - Icon-aware padding: a leading (left) icon reduces the left padding while the text side keeps the larger padding; no icon = symmetric Co-Authored-By: WOZCODE <contact@withwoz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Core Design button spec from Figma for SCI-13284.
What changed
Restyles the design-system
.btnso padding, radius and icon sizes follow the size scale (identical across all button types):4px → 8pxacross all sizes.:has(> .sn-icon:first-child)— no markup wrapper or side-class needed, since buttons only ever have a left icon or no icon.Files
app/assets/stylesheets/tailwind/buttons.cssapp/views/design_elements/_button.html.erb(showcase updated to match)Notes
/design_elements(dev-only).Jira: https://scinote.atlassian.net/browse/SCI-13284