added tcutils functions#207
Conversation
|
This is without the unit test. (I did regenerate already the API ns) Then I add the tests accordingly |
| {new-column-name (rolling/last column-name)}))) | ||
|
|
||
| ;; TODO is this the same as the "cumsum" from operators ? | ||
| (defn cumsum-col |
There was a problem hiding this comment.
This might exist already as column operator, correct ?
| (:import [java.text Normalizer Normalizer$Form])) | ||
|
|
||
| (defn to-kebab-case [string] | ||
| ;; TODO there is a librray for this : https://github.com/clj-commons/camel-snake-kebab |
There was a problem hiding this comment.
should I change and use csk library, assuming it does the same.
We probably have a transitive dependency to it already, but I can check
There was a problem hiding this comment.
yes, we have it already. So I suggest to use it.
| maps of columns. | ||
| - `:parser-fn` - | ||
| - `keyword?` - all columns parsed to this datatype. For example: | ||
| v - `keyword?` - all columns parsed to this datatype. For example: |
There was a problem hiding this comment.
This change comes from dataset....
I guess you did not "regenerate" the code after updating to TMD 8.x, so you did not see it.
I made a PR for it, but not merged yet:
techascent/tech.ml.dataset#473
I guess we leave it in, until changed upstream.
It's not a syntax error
|
On general thing: some functions should operate also on the grouped dataset - so we need to implement it as well. We can do this later. |
Ok, I did not think about it. |
|
should we merge this ? |
|
Merging this. However we need to work on grouped versions and update documentation. |
2 participants
adding functin from tcutils
https://github.com/scicloj/tcutils/tree/main