Context::getCurrentPath() returns indexes of list items#1325
Open
katin-dev wants to merge 1 commit into
Open
Conversation
Author
|
@goetas why Scrutinizer Canceled? What should I do to rerun it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing
ExclusionStrategyInterfacei realized that there is no way to detect if current element is part on the list with specific index.For example, we have a class
When one of
$childrenelement has been passed toshouldSkipProperty(PropertyMetadata $property, Context $context), i don't know which one.Contextdoes not know the index of such element. But i have external rules like so which define whether property of element should be serialized or not:I suggest
$context->getCurrentPath()should return array like so:[children][0]['name']instead of[children]['name'](current behavior)