[mitosis] Enrich trace output for cells - #3683
Open
tommy-u wants to merge 1 commit into
Open
Conversation
tommy-u
requested review from
dforsyth,
dschatzberg,
kkdwvd and
likewhatevs
and removed request for
dforsyth
July 2, 2026 22:28
kkdwvd
approved these changes
Jul 2, 2026
Contributor
|
Adding in a cell.cpus.to_cpulist() to print in there would be nice (for hex challenged folks). |
likewhatevs
approved these changes
Jul 2, 2026
dschatzberg
approved these changes
Aug 3, 2026
dschatzberg
left a comment
dschatzberg
left a comment
Contributor
There was a problem hiding this comment.
This looks good but I think we have a bug in collect_demand_metrics - see my inline comment.
|
|
||
| if delta_running == 0 && delta_lent == 0 { | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
Here we skip updating util_pct for an idle cell. This seems incorrect since it should effect util which is going to reflect in your trace output.
Contributor
There was a problem hiding this comment.
It also short-circuits from updating smoothed_util
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve cell TRACE output.
Cells used to print in unstable order, this sorts them by cell number.
Adds CPU count plus current/smoothed utilization, making rebalance/debug runs easier to inspect.
Before:
CELL[0]: fffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffffAfter:
... CELL[0]: fffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff,ffffffff (316 CPUs, util=2.7%, smoothed=1.8%)