Skip to content

Fix: raise docker client timeout so slow evals aren't silently scored unresolved #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robdmac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: raise docker client timeout so slow evals aren't silently scored unresolved #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion swe_bench_pro_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@

from helper_code.image_uri import get_dockerhub_image_uri

# Docker's default 60s client read timeout is too short for long-running test suites.
DOCKER_CLIENT_TIMEOUT = int(os.environ.get("DOCKER_CLIENT_TIMEOUT", "3600"))

# Credit: prabhuteja12
def load_base_docker(iid):
with open(f"dockerfiles/base_dockerfile/{iid}/Dockerfile") as fp:
Expand Down Expand Up @@ -378,7 +381,7 @@ def eval_with_docker(patch, sample, output_dir, dockerhub_username, scripts_dir,
dockerhub_image_uri = get_dockerhub_image_uri(uid, dockerhub_username, sample.get("repo", ""))
print(f"Using Docker Hub image: {dockerhub_image_uri}")

client = docker.from_env()
client = docker.from_env(timeout=DOCKER_CLIENT_TIMEOUT)
try:
if docker_platform:
client.images.pull(dockerhub_image_uri, platform=docker_platform)
Expand Down