Allow to prettify XML#59
Merged
tjarratt merged 1 commit intosavonrb:masterfrom Mar 4, 2016
Merged
Conversation
Contributor
|
Thanks @Jeiwan ! |
|
Please build a new version gem and push it to rubygems.org, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
:pretty_print,:indentand:compactoptions to allow prettified XML output.There is an old PR #35 that has the same purpose, but it stumbled over problems in Builder gem. In this PR I don't mess with Builder gem but instead use
REXMLfrom standard Ruby library to format generated XML.Prettifying doesn't work for XML documents generated from an array without
unwrapoption set totrueas such documents are not valid and cannot be formatted byREXML. This case is just bypassed, no exceptions thrown.