Skip to content

Fix build that got botched in merge #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amalnanavati wants to merge 4 commits into
base: ros2actionclient
Choose a base branch
from
Open

Fix build that got botched in merge #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39b6e96
Fixed build that got botched in merge
Apr 22, 2023
d8b4dfc
Remove console.log calls
Apr 22, 2023
a47019b
Downgrade Puppeteer to 19.2.0 due to arm64 compatibility issues
Apr 22, 2023
af51b15
Update README.md
amalnanavati Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
**NOTE** (April 2023): This [PRL fork of `roslibjs`](https://github.com/personalrobotics/roslibjs), and the corresponding [PRL fork of `rosbridge_suite`](https://github.com/personalrobotics/rosbridge_suite), is to account for the fact that the [official `rosbridge_suite`](https://github.com/RobotWebTools/rosbridge_suite) and [official `roslibjs`](https://github.com/RobotWebTools/roslibjs) do not currently work with ROS2 actions. [This is a PR to address that](https://github.com/RobotWebTools/rosbridge_suite/pull/813), and it formed the basis for these two PRL forks. If ROS2 action support is added to both `rosbridge_suite` and `roslibjs`, then these two PRL forks can be removed (and any code that uses them, like the [PRL `feeding_web_interface`](https://github.com/personalrobotics/feeding_web_interface), updated).

# roslibjs

[![CI](https://github.com/RobotWebTools/roslibjs/actions/workflows/main.yml/badge.svg)](https://github.com/RobotWebTools/roslibjs/actions/workflows/main.yml)
Expand Down
Loading