fix: correct server content ordering for numbered filenames#1847
Open
Wizzzzzzard wants to merge 8 commits into
Open
fix: correct server content ordering for numbered filenames#1847Wizzzzzzard wants to merge 8 commits into
Wizzzzzzard wants to merge 8 commits into
Conversation
…mes after 9 not 1) Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Wizzzzzzard
force-pushed
the
fix/correct-server-content-ordering-for-numbered-filenames
branch
from
April 2, 2026 13:04
190c71d to
7a0d585
Compare
Wizzzzzzard
marked this pull request as ready for review
April 2, 2026 13:05
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
dahils
added
testing
scottdover
reviewed
May 1, 2026
…to fix/correct-server-content-ordering-for-numbered-filenames
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Contributor
|
Hey @Wizzzzzzard . Our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the ordering of files and folders with numerical names so that they properly respect numerical order when sorting, i.e. a file named
test10.sasshould come aftertest9.sasnottest1.sas.Testing:
I made a series of files with numerical names beforehand and confirmed that sorting was incorrect:
I then made my changes and created several files and folders to confirm the new sorting was correct:
TODOs: