fix: reopens files that were opened when dragging and dropping files or folders by tarikutk · Pull Request #1704 · sassoftware/vscode-sas-extension

tarikutk · 2025-11-19T20:21:05Z

Summary:

it opens previously opened files when dragging and dropping a file or a folder.
it prevents VSCode from opening a folder as a file when moving a folder from one folder to another folder. it instead opens the file that was opened in that folder

Testing:
verified it opens previously opened files instead of opening a folder as a file.

Copilot

Pull Request Overview

This PR fixes file reopening behavior when dragging and dropping files or folders in the Content Navigator. It ensures that previously opened files are reopened at their new locations after a move operation, and prevents VSCode from incorrectly opening folders as files.

Key Changes:

Modified the moveTo handling logic to track closed files as an array instead of a boolean
Added a new calculateNewFileUri method to compute new URIs for files that were moved
Implemented logic to reopen all previously opened files after a successful move operation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

scottdover · 2025-12-05T14:27:33Z

Hey @tarikutk . Is there a github issue associated with this PR? Or rather, what issue is this solving?

tarikutk · 2025-12-08T01:38:24Z

Hey @tarikutk . Is there a github issue associated with this PR? Or rather, what issue is this solving?

yes @scottdover, there is a GitHub issue associated with it. I attached the link now in the PR message. it is #1478.

scottdover · 2026-01-15T14:43:08Z

Sorry for the delay in getting back to this one. At a high level, this is how the code is structured w/r/t file access.

ContentDataProvider exposes the data view to the ui via a treeview
ContentModel is responsible for handling the business logic related to file CRUD operations
ContentAdapter is an interface that defines the specific methods used in ContentModel to provide data back to the user
There are a few implementations of ContentAdapter
- ItcServerAdapter: For server files via an itc connection
- RestServerAdapter: For server files via a rest (viya) connection
- RestContentAdapter: For sas content via a rest (viya) connection

Your implementation has itc (relativePath.replace(/^~fs~/, "") as an example) & rest specific code (/(\/files\/[^&]*)/ as an example) in ContentDataProvider. Any code that is specific to a certain connection type should be nested in the relevant adapter.

tarikutk · 2026-02-18T12:31:03Z

I updated @scottdover .

tarikutk · 2026-02-18T12:35:15Z

the commit for itcServerAdapter is something which I was not able to test. and the last one is just to fix typescript issues. please let me know if itcServerAdapter works and if the fix for typescript breaks things. I will revert those if needed. Thanks

…or folders Signed-off-by: tariku <tarikutadese24@gmail.com>

Signed-off-by: tariku <tarikutadese24@gmail.com>

scottdover

This is looking a lot better...just a few minor things.

scottdover · 2026-06-29T13:10:52Z

+      const newFileUri = this.model
+        .getAdapter()
+        .calculateNewFileUri?.(closedFileUri, item, newUri);


Calls to adapter methods should be contained within a ContentModel (i.e. this should be this.model.calculateNewFileUri). It doesn't look like we expose adapter in any other content data provider methods.

scottdover · 2026-06-29T13:15:29Z


+export const extractPathFromUri = (uri: string): string => {
+  try {
+    const queryStart = uri.indexOf("?");


nitpick. We're doing this indexOf query param check here and below. Creating a small shared function to handle this functionality would prevent us from repeating ourselves.

scottdover · 2026-06-29T13:34:32Z

+  oldBasePath: string,
+  closedFilePath: string,
+  newItemUri: Uri,
+  dirSeparator: string,


There's no need to pass this in as a parameter. The function is available to call just above this one.

scottdover · 2026-06-29T13:37:19Z

+    const queryStart = uri.indexOf("?");
+    if (queryStart === -1) {
+      return "";
+    }
+
+    const queryString = uri.substring(queryStart + 1);


Seeing this behavior once more...if this behavior is shared across multiple connection types, a suitable place to define a helper function may be in client/src/connection/util

scottdover · 2026-06-29T13:39:21Z

+    const decodedQuery = decodeURIComponent(queryMatch[1]);
+    const newQuery = decodedQuery.replace(
+      /(\/files\/[^&]*)/,
+      `$1~fs~${filename}`,


Would it be possible to use SAS_FILE_SEPARATOR here and above (you'll likely need to change that to new RegExp(...)) instead of hard coding this?

tarikutk force-pushed the fix/drag/drop branch from 611c04f to 5d54593 Compare November 19, 2025 20:25

tarikutk changed the title ~~fix: opens closed file not the folder in drag/drop~~ fix: reopens files that were opened when dragging and dropping files or folders Nov 19, 2025

tarikutk force-pushed the fix/drag/drop branch from 5d54593 to 802bd3b Compare November 20, 2025 04:00

tarikutk marked this pull request as ready for review November 20, 2025 04:03

tarikutk requested review from Copilot and scottdover November 20, 2025 14:30

Copilot started reviewing on behalf of tarikutk November 20, 2025 14:30 View session

Copilot finished reviewing on behalf of tarikutk November 20, 2025 14:34

Copilot AI reviewed Nov 20, 2025

View reviewed changes

2TomLi requested a review from kpatl1 November 20, 2025 14:58

tarikutk force-pushed the fix/drag/drop branch from 82a3dc9 to af2da9a Compare November 21, 2025 17:42

scottdover reviewed Dec 5, 2025

View reviewed changes

Comment thread client/src/components/ContentNavigator/ContentDataProvider.ts Outdated

Comment thread client/src/components/ContentNavigator/ContentDataProvider.ts Outdated

tarikutk requested a review from scottdover December 8, 2025 01:41

tarikutk force-pushed the fix/drag/drop branch 2 times, most recently from 8d2e0f0 to 49b6eeb Compare February 18, 2026 12:24

scottdover requested review from smorrisj and removed request for kpatl1 February 20, 2026 18:28

scottdover reviewed Feb 20, 2026

View reviewed changes

tarikutk force-pushed the fix/drag/drop branch from 49b6eeb to e2db22e Compare February 25, 2026 21:19

tarikutk added 6 commits March 9, 2026 15:12

fix: reopens files that were opened when dragging and dropping files …

a3d8a93

…or folders Signed-off-by: tariku <tarikutadese24@gmail.com>

chore: refactor and print console.error on error

157dbf8

Signed-off-by: tariku <tarikutadese24@gmail.com>

chore: use SAS_FILE_SEPARATOR from restServerAdapter

3b08e8e

Signed-off-by: tariku <tarikutadese24@gmail.com>

chore: move calculateNewFileUri to the adapters

12dba34

Signed-off-by: tariku <tarikutadese24@gmail.com>

chore: implement calculateNewFileUri for itcServerAdapter

e59af72

Signed-off-by: tariku <tarikutadese24@gmail.com>

chore: refactor and break down functions to utils

c7481c0

Signed-off-by: tariku <tarikutadese24@gmail.com>

tarikutk force-pushed the fix/drag/drop branch from e2db22e to c7481c0 Compare March 9, 2026 19:16

scottdover reviewed Jun 29, 2026

View reviewed changes

tarikutk self-assigned this Jul 15, 2026

Uh oh!

Conversation

tarikutk commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

scottdover commented Dec 5, 2025

Uh oh!

Uh oh!

Uh oh!

tarikutk commented Dec 8, 2025

Uh oh!

scottdover commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarikutk commented Feb 18, 2026

Uh oh!

tarikutk commented Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

scottdover left a comment

Choose a reason for hiding this comment

Uh oh!

scottdover Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

scottdover Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

scottdover Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

scottdover Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

scottdover Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tarikutk commented Nov 19, 2025 •

edited

Loading

scottdover commented Jan 15, 2026 •

edited

Loading