Skip to content

fix(date picker) Add portal to date picker #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vekkele wants to merge 2 commits into
base: next
Choose a base branch
from
Open

fix(date picker) Add portal to date picker #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
256f500
fix(date picker) Add portal to date picker
vekkele Aug 4, 2026
c05b9a5
fix(date picker) Make portalTo an optional prop
vekkele Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lib/ui/core/Calendar/DatePicker.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
popoverContentProps?: ComponentProps<typeof Popover>['contentProps']
popoverIsOpened?: boolean
withTrigger?: boolean
portalTo?: ComponentProps<typeof Popover>['portalTo']
}

type TSingleProps = {
Expand Down Expand Up @@ -53,6 +54,7 @@
minDate = new Date(2009, 0, 1),
timeZone = BROWSER ? getLocalTimeZone() : 'utc',
popoverIsOpened = $bindable(false),
portalTo,
...rest
}: TProps = $props()

Expand Down Expand Up @@ -94,6 +96,7 @@
bind:isOpened={popoverIsOpened}
contentProps={rest.popoverContentProps}
children={withTrigger ? triggerSnippet : undefined}
{portalTo}
>
{#snippet content()}
{#if isRangeProps(rest)}
Expand Down
6 changes: 5 additions & 1 deletion src/lib/ui/core/Calendar/DoubleDatePicker/index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<script lang="ts">
import type { ComponentProps } from 'svelte'

import { CalendarDate, getLocalTimeZone } from '@internationalized/date'

import Popover from '$ui/core/Popover/index.js'
Expand All @@ -13,8 +15,9 @@
buttonClass?: string
rootClass?: string
onChange: (dates: [Date, Date]) => void
portalTo?: ComponentProps<typeof Popover>['portalTo']
}
let { dates, buttonClass, rootClass, onChange }: TProps = $props()
let { dates, buttonClass, rootClass, portalTo, onChange }: TProps = $props()

let { inputNode, onKeyDown, onInput, onClick, onBlur } = useInputCalendar(() => dates, onChange)

Expand All @@ -38,6 +41,7 @@
rootClass,
)}
bind:isOpened={() => isOpened, () => {}}
{portalTo}
contentProps={{
trapFocus: false,
onInteractOutside: (e) => {
Expand Down