Skip to content

Fix visibility prompt bug #6800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abelemlih wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix visibility prompt bug #6800

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c47a2e
Edit app/controllers/concerns/hyrax/works_controller_behavior.rb
abelemlih May 17, 2024
0b0297c
Edit app/controllers/concerns/hyrax/works_controller_behavior.rb
abelemlih May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions app/controllers/concerns/hyrax/works_controller_behavior.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,13 +496,14 @@ def save_permissions
end

def permissions_changed?
@saved_permissions !=
case curation_concern
when ActiveFedora::Base
curation_concern.permissions.map(&:to_hash)
else
Hyrax::AccessControl.for(resource: curation_concern).permissions
end
case curation_concern
when ActiveFedora::Base
@saved_permissions != curation_concern.permissions.map(&:to_hash)
else
new_permissions = Hyrax::AccessControl.for(resource: curation_concern).permissions
saved_permissions_set = @saved_permissions.to_set
new_permissions.size != @saved_permissions.size || new_permissions.any? { |e| !saved_permissions_set.include? e }
end
end

def concern_has_file_sets?
Expand Down