Repository navigation
feat(ios): group the calendar by day and show each release's details - #357
Merged
Merged
Conversation
The calendar lane repeated an ISO date on every row and showed nothing else. Rows now sit under sticky day headers (Today, Tomorrow, or the weekday and date) and carry the kind, the episode range, the TMDB score, whether the title is already in the library, a two-line synopsis and the streaming providers, all of which the upcoming endpoint already sends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Activity → Calendar lane repeated an ISO date on every row and showed nothing else about the release. The upcoming endpoint already sends much more, so this is an iOS-only change.
S1 E3–4when several air the same day), TMDB score, and a green "In library" when the title is already there.RawkoonKit(UpcomingCalendar) with unit tests.RAWKOON_ACTIVITY_LANElaunch variable opens an Activity lane directly, for simulator screenshots.Localization
New strings
TomorrowandDate to be announcedhave French entries. The kind label avoids a ternary soShow/Movieresolve through the catalog.scripts/check-l10n.pypasses.Verification
xcodebuildsimulator build on macOS: succeeded.swift test --filter "UpcomingCalendarTests|UpcomingReleaseTests": 9 tests, 0 failures.