fix: sync captions to native iOS fullscreen player#2888
Open
mkrn wants to merge 1 commit into
Open
Conversation
When using iosNative: true, captions were not displayed in the native iOS fullscreen video player. This was because Plyr sets all track modes to hidden to handle its own caption rendering, but the native iOS player only shows captions when track mode is showing. This fix: - Listens for webkitbeginfullscreen/webkitendfullscreen events - Sets the active caption track mode to showing when entering native fullscreen so iOS can render captions - Restores track mode to hidden when exiting so Plyr can resume controlling caption rendering Also fixes a bug where exit() was calling webkitEnterFullscreen() instead of webkitExitFullscreen(). Fixes sampotts#2732 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
Tested at preview URL with iPhone. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iosNative: true'showing'so iOS can render captions'hidden'so Plyr can resume controlling caption renderingexit()was callingwebkitEnterFullscreen()instead ofwebkitExitFullscreen()Test plan
iosNative: trueconfiguredFixes #2732
🤖 Generated with Claude Code