Fix pages when access control is true

[uda]

When GITLAB_PAGES_ACCESS_CONTROL is set to true the variable GITLAB_RELATIVE_URL_ROOT added recently is not being replaced causing pages to fail starting

[uda]

Just noting, I verified this by switching to a build in my docker-compose.yml, the variable GITLAB_VERSION is set in .env

services:
  gitlab:
    image: "my.docker.io.proxy/sameersbn/gitlab:${GITLAB_VERSION}"
    build:
      context: ./
      args:
        GITLAB_VERSION: ${GITLAB_VERSION}
    depends_on:

The Dockerfile:

ARG GITLAB_VERSION

FROM my.docker.io.proxy/sameersbn/gitlab:${GITLAB_VERSION}

COPY runtime-functions /etc/docker-gitlab/runtime/functions

Running docker compose build and docker compose up -d now I have the pages system up and running

[emotroshylov]

Hi @sachilles
Could you please take a look at this PR when you have some time?
This bug is still fully reproducible and completely breaks GitLab Pages on recent versions like v19.0.1 whenever GITLAB_PAGES_ACCESS_CONTROL is enabled.
This PR contains a solid fix that solves the problem. It would be awesome to get this reviewed and merged.
Thank you!

[sachilles]

@emotroshylov Thanks for the ping. I'm creating backports for all the other active versions.

[sachilles]

@uda Thank you for your contribution, and I apologize for the long wait.