Fix vault test container name collision across parameterized runs#68947
Open
dwoz wants to merge 3 commits intosaltstack:3006.xfrom
Open
Fix vault test container name collision across parameterized runs#68947dwoz wants to merge 3 commits intosaltstack:3006.xfrom
dwoz wants to merge 3 commits intosaltstack:3006.xfrom
Conversation
The vault_container_version fixture uses a hardcoded container name "vault" for all three parameterized versions (0.9.6, 1.3.1, latest). When the container from a prior parameterized run isn't fully removed before the next one starts, Docker returns a 409 Conflict. Use random_string to generate unique container names per run.
twangboy
previously approved these changes
Apr 16, 2026
Same fix as the functional vault tests - use random_string for the Docker container name to avoid 409 conflicts when parameterized fixture teardown overlaps with the next setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vault_container_version fixture uses a hardcoded container name "vault" for all three parameterized versions (0.9.6, 1.3.1, latest). When the container from a prior parameterized run isn't fully removed before the next one starts, Docker returns a 409 Conflict. Use random_string to generate unique container names per run.