Skip to content

Fix 'occured' -> 'occurred' typos in salt logging strings#68945

Closed
SAY-5 wants to merge 2 commits intosaltstack:3008.xfrom
SAY-5:fix-salt-occured-typos
Closed

Fix 'occured' -> 'occurred' typos in salt logging strings#68945
SAY-5 wants to merge 2 commits intosaltstack:3008.xfrom
SAY-5:fix-salt-occured-typos

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented Apr 15, 2026

Two log messages used occured instead of occurred:

  • salt/crypt.py:1258log.exception('Something unexpected occured loading master pub-key')
  • salt/cli/daemons.py:330log.error('An error occured while setting up the minion manager')

Both messages reach operators in salt-master / salt-minion logs. Python ast.parse stays clean for both files.

Two log messages used 'occured' instead of 'occurred':

  * salt/crypt.py: log.exception('Something unexpected occured loading
    master pub-key')
  * salt/cli/daemons.py: log.error('An error occured while setting up
    the minion manager')

Both messages reach operators in salt-master / salt-minion logs.
Python ast.parse stays clean for both files.
@SAY-5 SAY-5 requested a review from a team as a code owner April 15, 2026 18:25
twangboy
twangboy previously approved these changes Apr 15, 2026
@twangboy twangboy added documentation Relates to Salt documentation test:full Run the full test suite labels Apr 15, 2026
@twangboy twangboy added this to the Argon v3008.0 milestone Apr 15, 2026
@twangboy
Copy link
Copy Markdown
Contributor

Please address the pre-commit failure.

@SAY-5
Copy link
Copy Markdown
Author

SAY-5 commented Apr 16, 2026

@twangboy thanks for the review. Pushed a follow-up commit that black-wraps log.exception("Something unexpected occurred loading master pub-key") across multiple lines — the corrected spelling bumped the original one-liner over the line-length limit and pre-commit was flagging it. Should be clean now.

@SAY-5
Copy link
Copy Markdown
Author

SAY-5 commented Apr 16, 2026

@twangboy pre-commit is now passing (latest commit has black-wrapped log.exception to stay under the line limit). Mind taking another look?

@dwoz dwoz changed the base branch from master to 3008.x April 21, 2026 22:20
@SAY-5
Copy link
Copy Markdown
Author

SAY-5 commented Apr 28, 2026

Closing — typo-only PR. Multiple maintainers across the OSS ecosystem have flagged my recent typo-sweep PRs as AI-generated spam (notably hashicorp/nomad#27855, hashicorp/hcl#794, argo-cd reviewers). I should have caught this pattern sooner. Apologies for the noise.

@SAY-5 SAY-5 closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Relates to Salt documentation test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants