Fix 'occured' -> 'occurred' typos in salt logging strings#68945
Closed
SAY-5 wants to merge 2 commits intosaltstack:3008.xfrom
Closed
Fix 'occured' -> 'occurred' typos in salt logging strings#68945SAY-5 wants to merge 2 commits intosaltstack:3008.xfrom
SAY-5 wants to merge 2 commits intosaltstack:3008.xfrom
Conversation
Two log messages used 'occured' instead of 'occurred':
* salt/crypt.py: log.exception('Something unexpected occured loading
master pub-key')
* salt/cli/daemons.py: log.error('An error occured while setting up
the minion manager')
Both messages reach operators in salt-master / salt-minion logs.
Python ast.parse stays clean for both files.
twangboy
previously approved these changes
Apr 15, 2026
Contributor
|
Please address the pre-commit failure. |
Author
|
@twangboy thanks for the review. Pushed a follow-up commit that black-wraps |
Author
|
@twangboy pre-commit is now passing (latest commit has black-wrapped log.exception to stay under the line limit). Mind taking another look? |
Author
|
Closing — typo-only PR. Multiple maintainers across the OSS ecosystem have flagged my recent typo-sweep PRs as AI-generated spam (notably hashicorp/nomad#27855, hashicorp/hcl#794, argo-cd reviewers). I should have caught this pattern sooner. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two log messages used
occuredinstead ofoccurred:salt/crypt.py:1258—log.exception('Something unexpected occured loading master pub-key')salt/cli/daemons.py:330—log.error('An error occured while setting up the minion manager')Both messages reach operators in salt-master / salt-minion logs. Python
ast.parsestays clean for both files.