Skip to content

added background dim functionality for CascadePopup#45

Open
gsrathoreniks wants to merge 6 commits into
saket:trunkfrom
gsrathoreniks:feature/backgorundDim
Open

added background dim functionality for CascadePopup#45
gsrathoreniks wants to merge 6 commits into
saket:trunkfrom
gsrathoreniks:feature/backgorundDim

Conversation

@gsrathoreniks

Copy link
Copy Markdown

No description provided.

@gsrathoreniks

Copy link
Copy Markdown
Author

Fixed Issue : #3

@saket saket left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks gajendra!

Comment thread sample/src/main/java/me/saket/cascade/sample/SampleActivity.kt
dim.setBounds(0, 0, parent.width, parent.height)
dim.alpha = dimAmount
val overlay = parent.overlay
overlay.add(dim)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the showing and hiding of this overlay be animated?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added animation for applying dim and removing.

Comment thread cascade/src/main/java/me/saket/cascade/CascadePopupMenu.kt Outdated
@gsrathoreniks

Copy link
Copy Markdown
Author
animated_cascade_menu_bg.mp4

@gsrathoreniks gsrathoreniks requested a review from saket February 24, 2024 10:29
@gsrathoreniks

Copy link
Copy Markdown
Author

@saket can you please review. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants