bit field order in TPG descriptor byte0#455
Open
glagolig wants to merge 1 commit into
Open
Conversation
Re-arranging bit fields in scsi_target_port_group (representing unmarshalled data from RTPG commands) so that they match bits on the wire. Also fixing a typo in enum scsi_alua_state. Tested with iscsi-rtpg utility against a target with some groups having ALUA states other than "active-optimized". Before the change all states showed up as "active-optimized" (0). After the change the states showed as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-arranging bit fields in scsi_target_port_group (representing unmarshalled data from RTPG commands) so that they match bits on the wire.
Also fixing a typo in enum scsi_alua_state.
Tested with iscsi-rtpg utility against a target with some groups having ALUA states other than "active-optimized".
Before the change all states showed up as "active-optimized" (0). After the change the states showed as expected.