Migrate to ruff - #2524
Draft
Uxio0 wants to merge 3 commits into
Draft
Conversation
Add an asyncio-based AsyncEthereumClient that mirrors EthereumClient using AsyncWeb3/AsyncHTTPProvider + aiohttp, subclassing the sync client and managers and overriding only I/O so no business logic is duplicated. AsyncMulticall keeps batch_call at full parity with the sync Multicall path (raw revert bytes included). Refactor EthereumClient to extract I/O-free helpers shared by both clients (payload builders, batch-response processing, eth_call decode, tx error mapping, trace selectors, manager builders/formatters). Reuse the sync test suites against the async client via a sync-facade proxy. Fix bugs found during the refactor: - get_total_transfer_history double-counted transfers matching both from/to filters - send_unsigned_transaction returned an empty hash on exhausted retries (now raises) - functools.cache on instance methods leaked instances (per-instance cache + clear_cache)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: pending to merge other PRs to apply formatting