This repository was archived by the owner on Oct 27, 2025. It is now read-only.
Setup certora workflow - #96
Draft
akshay-ap wants to merge 16 commits into
Draft
Conversation
Pull Request Test Coverage Report for Build 6299064684
💛 - Coveralls |
… feature-95-formal-verification
… feature-95-formal-verification
akshay-ap
commented
Sep 25, 2023
| // execution metadata for transaction execution through plugin is encoded address of the plugin i.e. msg.sender. | ||
| // executionType = 1 for plugin flow | ||
| // should check below exist here? | ||
| checkPermittedModule(hooksAddress); |
Contributor
Author
There was a problem hiding this comment.
Should revert or skip if flagged?
akshay-ap
commented
Sep 25, 2023
| // execution metadata for transaction execution through plugin is encoded address of the plugin i.e. msg.sender. | ||
| // executionType = 1 for plugin flow | ||
| // should check below exist here? | ||
| checkPermittedModule(hooksAddress); |
Contributor
Author
There was a problem hiding this comment.
Should revert or skip if flagged?
akshay-ap
commented
Sep 25, 2023
| revert FunctionHandlerNotSet(account, functionSelector); | ||
| } | ||
|
|
||
| checkPermittedModule(functionHandler); |
Contributor
Author
There was a problem hiding this comment.
Should revert or skip if flagged?
Contributor
There was a problem hiding this comment.
In my opinion, since this doesn't affect the core execution flow, it's OK to revert here.
4player90
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95
Changes in PR:
certora.ymlCERTORA_KEYin github secretsAdd Rules and invariants
Additional properties: