Skip to content
This repository was archived by the owner on Oct 27, 2025. It is now read-only.

perf: state mutability and unused var - #135

Open
gosuto-inzasheru wants to merge 2 commits into
safe-fndn:mainfrom
gosuto-inzasheru:perf/state_mutability_and_unused_var
Open

perf: state mutability and unused var#135
gosuto-inzasheru wants to merge 2 commits into
safe-fndn:mainfrom
gosuto-inzasheru:perf/state_mutability_and_unused_var

Conversation

@gosuto-inzasheru

Copy link
Copy Markdown

Changes in PR:

  • perf: restrict state mutability to pure
  • perf: remove unused variable

implement performance recommendations from solidity compiler:

Warning: Unused local variable.
  --> contracts/test/TestFallbackReceiver.sol:13:24:
   |
13 |         (bool success, bytes memory data) = ethReceiver.call{value: address(this).balance}("");
   |                        ^^^^^^^^^^^^^^^^^


Warning: Function state mutability can be restricted to pure
   --> contracts/SafeProtocolRegistry.sol:122:5:
    |
122 |     function supportsInterface(bytes4 interfaceId) external view override returns (bool) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Function state mutability can be restricted to pure
   --> contracts/SignatureValidatorManager.sol:226:5:
    |
226 |     function supportsInterface(bytes4 interfaceId) external view override returns (bool) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Function state mutability can be restricted to pure
  --> contracts/test/TestPlugin.sol:21:5:
   |
21 |     function supportsInterface(bytes4 interfaceId) external view override returns (bool) {
   |     ^ (Relevant source part starts here and spans across multiple lines).

@KaliforniaShell KaliforniaShell left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants