This repository was archived by the owner on Oct 27, 2025. It is now read-only.
Refactor Storage Access to be 4337 Compatible - #128
Closed
nlordell wants to merge 2 commits into
Closed
Conversation
Pull Request Test Coverage Report for Build 6800133305
💛 - Coveralls |
nlordell
marked this pull request as ready for review
November 8, 2023 09:53
mmv08
approved these changes
Nov 8, 2023
Contributor
There was a problem hiding this comment.
Looks good to me. What do you think about adding comments to explain why the mappings are defined this way? I feel this could be helpful because having a mapping from an account to a module (or any other primitive) is more natural than doing it from a module to an account and then storing the reference to the outer mapping in the inner mapping. But maybe I'm the only one who feels this way.
Collaborator
Author
|
Closed in favour of #132 with branch name that matches contribution standards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the manager storage to use the
accountin the inner most mapping. This allows the Manager to be used with 4337 during signature validation. Note that tests continue to pass.I also noticed that most storage is
publicwith an addition direct accessor function. This generates additional code (for example, it generates both aenabledPlugins(address,address)function and agetPluginInfo(address,address)function unnecessarily). I think we should either generated accessor methods, or hand-written methods, but definitely not both. Since it is outside of the scope of this PR, I created a separate issue #130 to track this. The reason it is worth mentioning here is that this effectively changes theManagerinterface to be slightly different - the order of parameters in the generated accessors for the public mapping has changed, but the hand-written function accessors has not (hence, theManagerstill implementsISafeProtocolManagercorrectly).Related to #127