Wip 4.6.1 - #781
Open
bastien-roucaries wants to merge 13 commits into
Open
Conversation
Before this commit processMessageReply did not work for exceptions with a reccurent id in an other timezone than the dtstart of the master event.
…fied instances only
…change not very significant
The three tests were failing because DTSTAMP is now generated in the iTip messages but wasn't expected in the test assertions. Added DTSTAMP:**ANY** to the expected outputs to match the actual behavior. Fixed tests: - BrokerNewEventTest::testSimpleInviteWithAlarm - BrokerUpdateEventTest::testSimpleInviteWithAlarm - BrokerUpdateEventTest::testLocationChange 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Test case for linagora/esn-sabre#50 When DTSTART is in April but RRULE specifies BYMONTH=5 (May) and BYMONTHDAY=15, the first occurrence should be May 15, not April 15. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
When a YEARLY recurrence rule specifies BYMONTH (and optionally BYMONTHDAY/BYDAY), and the DTSTART is in a different month than those specified in BYMONTH, the first occurrence should be the first valid date according to the rule, not the DTSTART itself. For example, with: - DTSTART: April 11, 2030 - RRULE: FREQ=YEARLY;BYMONTH=5;BYMONTHDAY=15 The first occurrence should be May 15, 2030 (not April 11 or April 15). This fix modifies rewind() to check if the DTSTART is a valid occurrence according to BYMONTH rules, and if not, advances to the first valid occurrence. Fixes: linagora/esn-sabre#50 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
@phil-davis A gentle reminder, I can split if needed but I will need guidance for helping you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @phil-davis
The remaining change of linagora, for cherry picking may be
Feel free to ask more detail
rouca