Skip to content

PHPstan level 2 - #498

Open
JeroenVanOort wants to merge 9 commits into
sabre-io:masterfrom
webparking:phpstan-level-2
Open

PHPstan level 2#498
JeroenVanOort wants to merge 9 commits into
sabre-io:masterfrom
webparking:phpstan-level-2

Conversation

@JeroenVanOort

Copy link
Copy Markdown
Contributor

There was no other way to make this happen than to make a custom PHPStan extension.

@codecov

codecov Bot commented Feb 2, 2020

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.93814% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.68%. Comparing base (d529dda) to head (b40b250).
⚠️ Report is 355 commits behind head on master.

Files with missing lines Patch % Lines
lib/FreeBusyGenerator.php 97.14% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #498      +/-   ##
============================================
+ Coverage     98.33%   98.68%   +0.35%     
- Complexity     1757     1760       +3     
============================================
  Files            67       66       -1     
  Lines          4328     4272      -56     
============================================
- Hits           4256     4216      -40     
+ Misses           72       56      -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread lib/Cli.php Outdated
@phil-davis

Copy link
Copy Markdown
Contributor

@JeroenVanOort I merged PR #500 that "standardizes" more CI stuff.
Sorry, now you have conflicts.
Please rebase and resolve...

@phil-davis
phil-davis requested review from evert and staabm March 1, 2020 15:48
@phil-davis

Copy link
Copy Markdown
Contributor

@JeroenVanOort this has been sitting for a while and now has conflicts. Are you able to rebase and resolve them again?

@phil-davis
phil-davis self-requested a review February 12, 2021 00:06
@staabm
staabm removed their request for review July 22, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants