Skip to content

[5.1] fix: Do no sort listeners differently depending on their type #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phil-davis merged 2 commits into from
Jul 7, 2026
Merged

[5.1] fix: Do no sort listeners differently depending on their type #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baadb7c
fix: Do no sort listeners differently depending on their type
come-nc Jul 6, 2026
5cd7d4d
fix: convert to traditional closure for old PHP
phil-davis Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/WildcardEmitterTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,29 +126,28 @@ public function listeners(string $eventName): array
if (!\array_key_exists($eventName, $this->listenerIndex)) {
// Create a new index.
$listeners = [];
$listenersPriority = [];
if (isset($this->listeners[$eventName])) {
foreach ($this->listeners[$eventName] as $listener) {
$listenersPriority[] = $listener[0];
$listeners[] = $listener[1];
$listeners[] = $listener;
}
}

foreach ($this->wildcardListeners as $wcEvent => $wcListeners) {
// Wildcard match
if (\substr($eventName, 0, \strlen($wcEvent)) === $wcEvent) {
foreach ($wcListeners as $listener) {
$listenersPriority[] = $listener[0];
$listeners[] = $listener[1];
$listeners[] = $listener;
}
}
}

// Sorting by priority
\array_multisort($listenersPriority, SORT_NUMERIC, $listeners);
\usort($listeners, static function ($l1, $l2) {
return $l1[0] <=> $l2[0];
});

// Creating index
$this->listenerIndex[$eventName] = $listeners;
$this->listenerIndex[$eventName] = \array_column($listeners, 1);
}

return $this->listenerIndex[$eventName];
Expand Down