Draft
Conversation
This test changes flags and bits to make the object invalid, and checks that `is_valid()` catches it. It always reverts that change after every test. As a result, there is an assignment at the end to make the object valid again, with no check remaining afterwards. For me, the compiler complains about that, so add a final assertion to make it happy. Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
vhost_kern requires physical `GuestMemory` (uses `.get_host_address()`), so we have to restrict its `GuestAddressSpace` requirement to physical memory only. In this patch, that is not actually a restriction, but with vm-memory 0.18, there is going to be a difference between physical and potentially non-physical memory (`GuestMemoryBackend` vs. `GuestMemory`). Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Update our vm-memory and vm-virtio dependencies to a version with IOMMU (i.e. non-physical `GuestMemory` and `IommuMemory`) support. In some places, that means we need to import `GuestMemoryBackend` now to retain access to that trait’s methods. (`GuestMemoryBackend` is what used to be `GuestMemory`.) For vhost_kern, it means we need to have `PhysicalGuestAddressSpace` require `GuestMemoryBackend` instead of `GuestMemory` because, as explained in HEAD^, it strictly requires physical memory, and that is what `GuestMemoryBackend` is. (Marked as a draft until all of the updated dependencies have had proper releases and this commit just bumps their version number instead of pointing to non-released commits.) Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This PR updates the vm-memory dependency to 0.18.
It’s a draft because it needs virtio-queue and virtio-bindings (from vm-virtio) to have releases with the same dependency bump, so for now, the last patch uses
[patch.crates-io]to point to the github repo.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test. (None added.)
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented. (None added.)