Improve collect-changes script - #287
Merged
Merged
Conversation
phil-opp
commented
Aug 3, 2026
phil-opp
commented
Member
- collect-changes: switch from octocrab to reqwest
- collect-changes: use jiff instead of chrono
octocrab builds its own hyper client that doesn't honor HTTPS_PROXY, which prevents collect-changes from running in sandboxed environments that route all outbound traffic through a forward proxy. Replace it with plain reqwest, which respects the standard proxy env vars. The only octocrab surface used was two paginated GitHub list endpoints (org sources + PRs per repo), so the rewrite is small: minimal serde structs for the fields we read, plus a Link-header pagination helper. Output is byte-identical to the octocrab version on the same input. Also drops the deprecated chrono::DateTime::date() call along the way.
jiff's Zoned type has direct helpers for what we want (first_of_month, start_of_day) that would otherwise be a few lines of civil-date and NaiveDateTime juggling in chrono, and its API separates timezone-aware arithmetic from Timestamp arithmetic more cleanly. Output is byte-identical to before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.