Skip to content

Use GitHub relative-time-element library to display elapsed time#2410

Open
Urgau wants to merge 1 commit into
rust-lang:masterfrom
Urgau:gh-comments-relative-time
Open

Use GitHub relative-time-element library to display elapsed time#2410
Urgau wants to merge 1 commit into
rust-lang:masterfrom
Urgau:gh-comments-relative-time

Conversation

@Urgau
Copy link
Copy Markdown
Member

@Urgau Urgau commented May 25, 2026

Seems like toLocaleString JS function is not perfect and can be confusing to user when displaying the datetime, in particular due to day/month vs month/user confusion.

Instead of displaying the exact date time, let's use GitHub own relative-time-element library to display elapsed time instead.

Currently This PR
image image
image image

Fixes #2408
cc @RalfJung

@Urgau Urgau requested a review from Kobzol May 25, 2026 20:55
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 25, 2026

Static files in src/gh_comments/ were modified, make sure to update their version number in src/gh_comments.rs to bust the client cache.

Copy link
Copy Markdown
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's cool that it is available as a standalone library.

View changes since this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ambiguous date format in gh-comments

3 participants