Skip to content

Keep the GraphQl end cursor to avoid getting the data twice #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Urgau merged 1 commit into from
May 16, 2026
+9 −3
Merged

Keep the GraphQl end cursor to avoid getting the data twice #2406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/github/queries/issue_with_comments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,9 +416,15 @@ query ($owner: String!, $repo: String!, $issueNumber: Int!, $commentsCursor: Str
let reviews_cursor_changed = reviews_end_cursor != reviews_cursor;

// Update cursors for next iteration
comments_cursor = comments_end_cursor;
review_threads_cursor = review_threads_end_cursor;
reviews_cursor = reviews_end_cursor;
if comments_end_cursor.is_some() {
comments_cursor = comments_end_cursor;
}
if review_threads_end_cursor.is_some() {
review_threads_cursor = review_threads_end_cursor;
}
if reviews_end_cursor.is_some() {
reviews_cursor = reviews_end_cursor;
}

// Early return if first page has no more pages for any field (1 API call)
if all_comments.is_empty()
Expand Down