Skip to content

Fix compound assignments in liveness check#157066

Closed
chenyukang wants to merge 1 commit into
rust-lang:mainfrom
chenyukang:yukang-fix-154457-compound-assignment-read
Closed

Fix compound assignments in liveness check#157066
chenyukang wants to merge 1 commit into
rust-lang:mainfrom
chenyukang:yukang-fix-154457-compound-assignment-read

Conversation

@chenyukang
Copy link
Copy Markdown
Member

@chenyukang chenyukang commented May 28, 2026

Fixes #154457

r? @ghost

Let's do a perf run, I assume there will be some trivial regression on perf:

@bors try @rust-timer queue

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 28, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 28, 2026
…ent-read, r=<try>

Fix compound assignments in liveness check
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 28, 2026

☀️ Try build successful (CI)
Build commit: 6d9873d (6d9873daccf14745d652a8e0c93dbaba6bbc066e, parent: b5e038d7158c1af55a646027fdacf5ecd7c783c7)

@chenyukang
Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 28, 2026
…ent-read, r=<try>

Fix compound assignments in liveness check
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 28, 2026

☀️ Try build successful (CI)
Build commit: 31dbf74 (31dbf74d42d6559a579fa7b09f1d9311edfd1bcb, parent: cced03bfd61a304243a34504618ecec86c17063f)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (31dbf74): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.2% [0.1%, 0.3%] 15
Regressions ❌
(secondary)
0.2% [0.1%, 0.3%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.1%, 0.3%] 15

Max RSS (memory usage)

Results (primary 2.4%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
5.2% [3.2%, 7.4%] 3
Regressions ❌
(secondary)
0.9% [0.9%, 0.9%] 1
Improvements ✅
(primary)
-1.7% [-2.5%, -1.0%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.4% [-2.5%, 7.4%] 5

Cycles

Results (primary 2.5%, secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)
2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.5% [2.5%, 2.5%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 511.528s -> 511.622s (0.02%)
Artifact size: 400.68 MiB -> 400.66 MiB (-0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 29, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 30, 2026

☔ The latest upstream changes (presumably #157121) made this pull request unmergeable. Please resolve the merge conflicts.

@chenyukang
Copy link
Copy Markdown
Member Author

closing it since there are performance regression.

@chenyukang chenyukang closed this Jun 6, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unused_assignments on MIR warns on earlier compound assignment in a read-modify-write chain

3 participants