Unsafe kept in help text by ariagivens · Pull Request #156791 · rust-lang/rust

ariagivens · 2026-05-21T07:29:14Z

Currently when encountering a malformed attribute, the compiler will suggest removing unsafe in the well-formed template even when unsafe is required. This PR preserves whatever unsafe (or lack) exists in the user's code.

r? @jdonszelmann

rustbot · 2026-05-21T07:29:18Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-05-21T07:29:21Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

Kivooeo · 2026-05-21T07:56:26Z

Hey, I think Jana might be a bit busy because of Rustweek thing, do you mind if I take a look?

JonathanBrouwer · 2026-05-21T07:58:57Z

    pub fn suggestions(
        &self,
        style: AttrSuggestionStyle,
+        wrap_with_unsafe: bool,


I'd prefer to pass the Safety in here, instead of a bool

View changes since the review

rustbot · 2026-05-21T07:59:21Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-05-21T08:54:33Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

ariagivens · 2026-05-21T08:58:50Z

@rustbot ready

ariagivens · 2026-05-21T09:04:28Z

First time contributing to rustc after Jana's excellent workshop. Would related changes like suggesting:

- #[unsafe(export_name = ident)]
+ #[unsafe(export_name = "ident")]

go in this PR or a new one?

Kivooeo · 2026-05-21T10:15:58Z

go in this PR or a new one?

Sounds like a something for a new PR

Kivooeo

Looks good to me, @JonathanBrouwer how you feel about it?

View changes since this review

JonathanBrouwer

@bors r=JonathanBrouwer,Kivooeo rollup

View changes since this review

rust-bors · 2026-05-21T10:20:39Z

📌 Commit 970cb15 has been approved by JonathanBrouwer,Kivooeo

It is now in the queue for this repository.

…uwer Rollup of 2 pull requests Successful merges: - #156242 (Remove unsound `target_feature_inline_always` feature) - #156791 (Unsafe kept in help text)

@jdonszelmann

Rollup merge of #156791 - obi1kenobi:unsafe-kept-in-help-text, r=JonathanBrouwer,Kivooeo Unsafe kept in help text Currently when encountering a malformed attribute, the compiler will suggest removing unsafe in the well-formed template even when unsafe is required. This PR preserves whatever unsafe (or lack) exists in the user's code. r? @jdonszelmann

JonathanBrouwer · 2026-05-21T15:50:02Z

@rust-timer build c5fccf7

rust-timer · 2026-05-21T17:11:06Z

Finished benchmarking commit (c5fccf7): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.1%, secondary -1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.5%, -3.3%]	2
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	34
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	6
All ❌✅ (primary)	-0.0%	[-0.1%, -0.0%]	34

Bootstrap: 514.377s -> 517.8s (0.67%)
Artifact size: 400.61 MiB -> 400.56 MiB (-0.01%)

JonathanBrouwer · 2026-05-21T18:12:20Z

Perf is noise

obi1kenobi and others added 2 commits May 18, 2026 17:24

Make attr template suggestions preserve attribute safety.

835004a

Make attr template suggestions preserve attribute safety.

9c9f439

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 21, 2026

rustbot assigned jdonszelmann May 21, 2026

JonathanBrouwer requested changes May 21, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2026

Use ast node instead of boolean

970cb15

ariagivens requested a review from JonathanBrouwer May 21, 2026 08:58

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2026

Kivooeo approved these changes May 21, 2026

View reviewed changes

JonathanBrouwer approved these changes May 21, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2026

JonathanBrouwer mentioned this pull request May 21, 2026

Rollup of 2 pull requests #156794

Merged

rust-bors Bot merged commit f84347a into rust-lang:main May 21, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone May 21, 2026

This comment has been minimized.

Sign in to view

Uh oh!

Conversation

ariagivens commented May 21, 2026

Uh oh!

rustbot commented May 21, 2026

Uh oh!

rustbot commented May 21, 2026

Uh oh!

Kivooeo commented May 21, 2026

Uh oh!

JonathanBrouwer May 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented May 21, 2026

Uh oh!

rustbot commented May 21, 2026

Uh oh!

ariagivens commented May 21, 2026

Uh oh!

ariagivens commented May 21, 2026

Uh oh!

Kivooeo commented May 21, 2026

Uh oh!

Kivooeo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented May 21, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented May 21, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 21, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

JonathanBrouwer May 21, 2026 •

edited by rustbot

Loading

Kivooeo left a comment •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading