Region inference: split results from RegionInferenceContext by amandasystems · Pull Request #151688 · rust-lang/rust

amandasystems · 2026-01-26T14:43:18Z

What?

This PR turns RegionInferenceContext into a builder that produces the inferred region values, InferredRegions. The resulting struct implements the public API of RegionInferenceContext and replaces it in consumers.rs. RegionInferenceContext::solve() now consumes (moves) the inference context. It is completely private to region inference.

Why?

RegionInferenceContext has become a huge dump for various values people want to access.
region_infer itself is a very large file that's difficult to find your way around.
Polonius wants to skip as much of region inference as possible, since most of it is redundant. This makes that possible
No method now need warnings about being called after region inference or else they'll panic
RegionInferenceContext now takes almost all of its fields by reference
We can probably drop at least some stuff earlier
Data dependencies during region inference are now made more explicit

Knock-on effects

Region constraint (blame) search is now independent of a RegionInferenceContext
Less data is retained after region inference. This may or may not lead to minor improvements in memory use.
RegionInferenceContext now almost exclusively contains references to values, as opposed to owning them. This addresses most of fn compute_closure_requirements_modulo_opaques shouldn't clone all its inputs #146079
This reduces the coupling between region inference and Polonius-next, making it possible to skip region inference if it is not needed to check universal regions or type tests.
region_infer gains two child modules and becomes a lot less of a behemoth.

Detailed overview of changes

new modules: region_infer::constraint_search and region_infer::universal_regions.
handle_placeholders now consumes less input and does constraint rewriting via mutable references
consumers.rs now has a InferenceResults instead of a RegionInferenceContext
The public methods eval_{equal, outlives} are moved to InferredRegions
Constraint (blame) search, MIR dumping, graphviz rendering, and checking universal regions now all get their own builder-style structs, and the methods for their respective tasks are moved onto them
The option for region inference results in ConsumerOptions is now called InferredRegions
calculate_borrows_out_of_scope_at_location of course now takes InferredRegions
LivenessValues for free regions is now initialised as live at all points along with the constraint rewriting during placeholder handling, as opposed to during construction of RegionInferenceContext
Some trace logging, especially during constraint search, is lost since the data required to print the logs was only necessary to print the logs and never used otherwise.

Left to cut

Currently PlaceholderIndices are still cloned to avoid being moved out of MirTypeckRegionConstraints. Getting them out of RegionValues is complicated since they are needed to iterate over placeholders, and they can't easily be moved out of MirTypeckRegionConstraints. The obvious solution would be to Rc them, but that's not possible either because they are modified while they reside inside MirTypeckRegionConstraints. By the time they're actually used they're not mutated anymore though, which I've illustraded by Frozen:freeze()'ing them in this version.

I didn't want to give MirTypeckRegionConstraints the same treatment as I did RegionInferenceContext to keep this already very very large change as manageable as possible.

r? @lcnr

Closes #146079.

lcnr · 2026-02-12T17:09:02Z

+    liveness: &LivenessValues,
    pass_where: PassWhere,
    out: &mut dyn io::Write,
 ) -> io::Result<()> {


pls use a consistent function param ordering between the functions here :<

lcnr · 2026-02-12T17:14:26Z

+        let (definitions, _has_placeholders) = region_definitions(
+            infcx,
+            universal_regions,
+            &mut constraints.liveness_constraints.clone(),


this is... very odd. You give a mutable reference to a clone?

please move the cloned thing into a let binding first

That's a quick hack workaround, I think we should talk about how to not have to do that, where to put region_definitions(), and whether the liveness constarints stuff is necessary in sync because it's pretty much the same thing.

lcnr · 2026-02-12T17:17:03Z

+    outlives_constraints: &'a OutlivesConstraintSet<'tcx>,
+    mut w: &mut dyn Write,
+) -> io::Result<()> {
+    dot::render(&RawConstraints { tcx, region_definitions, outlives_constraints }, &mut w)


why reference RawConstraints. That type should be Copy

It's because dot::render() takes its arguments by reference (and it wasn't written by me).

lcnr · 2026-02-12T17:17:29Z

+    dot::render(&SccConstraints { tcx, region_definitions, constraint_sccs, nodes_per_scc }, &mut w)
 }

 struct RawConstraints<'a, 'tcx> {


make this copy and take it by value

lcnr · 2026-02-12T17:17:41Z

    nodes_per_scc: IndexVec<ConstraintSccIndex, Vec<RegionVid>>,
+    region_definitions: &'a IndexVec<RegionVid, RegionDefinition<'tcx>>,
+    constraint_sccs: &'a ConstraintSccs,
 }


lcnr · 2026-02-12T17:21:57Z

+            outlives_requirements.as_mut(),
+            &mut errors_buffer,
+            type_tests,
+        );


hmm, I would prefer check_type_tests to stay on the region inference context 🤔

they are a part of region inference to me

or like, the RegionInferenceCtxt should either not exist at all anymore, or still be used for the region computations 🤔 maybe chat about it in sync

lcnr · 2026-02-12T17:25:53Z

+        if let NllRegionVariableOrigin::FreeRegion = origin {
+            // Add all nodes in the CFG to liveness constraints for free regions
+            liveness_constraints.add_all_points(rvid);
+        }


this is a functional change? 🤔

It should not be, this always happens during region inference, I just moved it slightly earlier.

rust-timer · 2026-03-09T16:46:39Z

Finished benchmarking commit (1ee78dc): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.7%]	11
Regressions ❌ (secondary)	0.3%	[0.2%, 0.5%]	15
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.1%, 0.7%]	11

Max RSS (memory usage)

Results (secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.555s -> 479.91s (0.07%)
Artifact size: 395.03 MiB -> 394.99 MiB (-0.01%)

apiraino · 2026-05-07T13:09:32Z

I think the perf. run needs a comment (there are indications of regressions). Switching to waiting on author to incorporate changes. Feel free to request a review with @rustbot ready, thanks!

@rustbot author

rustbot · 2026-05-07T13:09:37Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

This ensures all of region inference is immutable, and makes every operation that requires region inference to have been executed to run explicitly require the results.

rustbot · 2026-05-26T15:41:00Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

amandasystems · 2026-05-26T15:41:31Z

This fixes the perf regression in one of the benchmarks on my machine (tm) and is even a net improvement in the benchmark I tried.

@rustbot ready

panstromek · 2026-05-27T08:33:00Z

I assume you want to check this again.

@bors try @rust-timer queue

Region inference: split results from RegionInferenceContext

rust-bors · 2026-05-27T10:43:46Z

☀️ Try build successful (CI)
Build commit: 6f40de9 (6f40de990a4c7cce34242d1930a5d7fa8ebaab16, parent: 2cfb951a24de2520de67f6911fd1fc0045a2662e)

rust-timer · 2026-05-27T11:24:48Z

Finished benchmarking commit (6f40de9): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	2
Regressions ❌ (secondary)	0.3%	[0.1%, 0.4%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	2

Max RSS (memory usage)

Results (secondary -3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -2.0%, secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[3.4%, 3.4%]	1
Improvements ✅ (primary)	-2.0%	[-2.5%, -1.5%]	3
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-2.0%	[-2.5%, -1.5%]	3

Binary size

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	4
All ❌✅ (primary)	-	-	0

Bootstrap: 510.57s -> 510.675s (0.02%)
Artifact size: 400.65 MiB -> 400.61 MiB (-0.01%)

rustbot assigned lcnr Jan 26, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 26, 2026

This comment has been minimized.

Sign in to view

amandasystems force-pushed the split-region-inference branch from 6befd69 to 13a57f6 Compare January 26, 2026 14:50

This comment has been minimized.

Sign in to view

amandasystems force-pushed the split-region-inference branch from 13a57f6 to 00e8121 Compare January 26, 2026 16:12

lcnr reviewed Jan 27, 2026

View reviewed changes

Comment thread compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs Outdated

amandasystems force-pushed the split-region-inference branch from 00e8121 to 454f98a Compare January 28, 2026 22:21

This comment has been minimized.

Sign in to view

lcnr reviewed Feb 3, 2026

View reviewed changes

Comment thread compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs Outdated

amandasystems force-pushed the split-region-inference branch from 4c01f95 to 174023c Compare February 6, 2026 14:58

This comment has been minimized.

Sign in to view

lcnr reviewed Feb 12, 2026

View reviewed changes

Comment thread compiler/rustc_borrowck/src/region_infer/mod.rs Outdated

lcnr reviewed Feb 12, 2026

View reviewed changes

Comment thread compiler/rustc_borrowck/src/region_infer/mod.rs Outdated

lcnr reviewed Feb 12, 2026

View reviewed changes

Comment thread compiler/rustc_borrowck/src/diagnostics/find_use.rs Outdated

lcnr reviewed Feb 12, 2026

View reviewed changes

Comment thread compiler/rustc_borrowck/src/diagnostics/opaque_types.rs Outdated

lcnr reviewed Feb 12, 2026

View reviewed changes

Comment thread compiler/rustc_borrowck/src/diagnostics/region_name.rs Outdated

lcnr reviewed Feb 12, 2026

View reviewed changes

Comment thread compiler/rustc_borrowck/src/diagnostics/region_name.rs Outdated

lcnr reviewed Feb 12, 2026

View reviewed changes

Comment thread compiler/rustc_borrowck/src/diagnostics/region_name.rs Outdated

lcnr reviewed Feb 12, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 9, 2026

This comment has been minimized.

Sign in to view

fee1-dead mentioned this pull request Mar 18, 2026

refactor(borrowck): less cloning in compute_closure_requirements_modulo_opaques swe-productivity/rust#9

Merged

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2026

amandasystems force-pushed the split-region-inference branch from 447cc9d to 685b895 Compare May 25, 2026 14:39

This comment has been minimized.

Sign in to view

amandasystems added 3 commits May 26, 2026 17:40

Region inference: split results from RegionInferenceContext

2146760

This ensures all of region inference is immutable, and makes every operation that requires region inference to have been executed to run explicitly require the results.

Avoid recomputing the constraint graph

42f65e9

These clones are no longer needed.

c5fad6f

amandasystems force-pushed the split-region-inference branch from 2198237 to c5fad6f Compare May 26, 2026 15:40

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 26, 2026

Work around one final clone

f172f44

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 27, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 27, 2026

Auto merge of #151688 - amandasystems:split-region-inference, r=<try>

6f40de9

Region inference: split results from RegionInferenceContext

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 27, 2026

Uh oh!

Conversation

amandasystems commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

Knock-on effects

Detailed overview of changes

Left to cut

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

rust-timer commented Mar 9, 2026

Overall result: ❌ regressions - please read the text below

Uh oh!

This comment has been minimized.

apiraino commented May 7, 2026

Uh oh!

rustbot commented May 7, 2026

Uh oh!

This comment has been minimized.

rustbot commented May 26, 2026

Uh oh!

amandasystems commented May 26, 2026

Uh oh!

panstromek commented May 27, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented May 27, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 27, 2026

Overall result: ❌ regressions - please read:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

amandasystems commented Jan 26, 2026 •

edited

Loading