Fix wrong question_mark suggestion when match arm body is a destructuring assignment

[charlieHsiuC]

• Added && sugg.starts_with('{') to the block-insertion branch. When the snippet doesn't start with { (i.e., destructuring assignment), it falls through to the else branch which correctly wraps the suggestion in an explicit block.
• Added a new test case issue_destructuring_assignment in tests/ui/question_mark.rs to verify that the lint provides correct suggestion for match expressions with destructuring assignments that can be replaced by the ? operator.

fixes #16862

changelog: [question_mark]: Fix wrong suggestion when match arm body is a destructuring assignment

[rustbot]

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 7 candidates
• 7 candidates expanded to 7 candidates
• Random selection from Jarcho, dswij, llogiq, samueltardieu

[llogiq]

Looks good to me. Thank you.

View changes since this review