fix(html): fix sidebar highlight when README is not first#3105
Open
leno23 wants to merge 1 commit into
Open
Conversation
On the book index page, only highlight the first chapter via the index alias. Skip exact `index.html` matches for later chapters whose README was renamed to index (issue rust-lang#2883). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
index.htmlshows the first chapter, the sidebar incorrectly highlighted both the first chapter and any later chapter whoseREADME.mdwas renamed toindex.htmlby the index preprocessor.Only apply the index-page alias to the first TOC entry; skip exact
index.htmlhref matches for other entries.Fixes #2883.
Test plan
sidebar-readme-not-first.gomlMade with Cursor